Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active selection + textbox is bugging #5152

Closed
blobinabottle opened this issue Aug 8, 2018 · 5 comments · Fixed by #5153 or #5261
Closed

Active selection + textbox is bugging #5152

blobinabottle opened this issue Aug 8, 2018 · 5 comments · Fixed by #5153 or #5261

Comments

@blobinabottle
Copy link
Contributor

Version

2.3.0

Test Case

KitchenSink

Steps to reproduce

Edit a text, next click and drag to make an active selection but release the mouse on top of text that you were editing. It will put that textbox back in editing mode. And it's mixing editing mode with selection mode...
Check the video here: https://cl.ly/0U2D1g2u3m0s

Expected Behavior

Keep all textbox in selection mode

Actual Behavior

Textbox are switched in editing mode with no reason

@asturur
Copy link
Member

asturur commented Aug 8, 2018

uh ok this needs a fix definetely.

@asturur
Copy link
Member

asturur commented Aug 8, 2018

@blobinabottle check the PR, looks good to me testing manually.
Need to add a test for it

@blobinabottle
Copy link
Contributor Author

@asturur seems to be fixed! Can't reproduce it! Thanks!

@blobinabottle
Copy link
Contributor Author

blobinabottle commented Aug 17, 2018

Sorry still an issue: now if you shift + double click you enter editing text but you can sill interact with other objects (while keeping the text in editing mode).
https://cl.ly/0009312X3i08

@blobinabottle blobinabottle reopened this Aug 17, 2018
@asturur
Copy link
Member

asturur commented Aug 17, 2018

ok i ll first fnd a way to test interactions with tests and then i will eventually fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants