Event before:selection:cleared doesn't receive the actual target

[0ro]

Version

2.7.0

Test Case

https://jsfiddle.net/DenBogdanov/9t0wdvs5/

Information about environment

browser

Steps to reproduce

Open console in jsfiddle, select two objects and then deselect them

Expected Behavior

Event listener of before:selection:cleared must to receive the ActiveSelection.

Actual Behavior

Event listener of selection:created receives in field target value of ActiveSelection, but event listener of before:selection:cleared receives the first object of ActiveSelection.

[0ro]

I don't understand why is in code this behavior with currentActives[0]

    discardActiveObject: function (e) {
      var currentActives = this.getActiveObjects();
      if (currentActives.length) {
        this.fire('before:selection:cleared', { target: currentActives[0], e: e });
      }
      this._discardActiveObject(e);
      this._fireSelectionEvents(currentActives, e);
      return this;
    }

I can try to fix it.

[asturur]

good question. looks wrong to me.
I think the point is that in the moment the deselection happen, the active selection gets destroyed, the objects mutated back, and you are basically working on invalid targets.

The event should be fired with the current active selection, since we are releasing a breaking release i think we should fix this now.

[0ro]

Great job!