Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep init fails on github.com/kr/pty #2

Closed
carolynvs opened this issue Jul 26, 2017 · 1 comment
Closed

dep init fails on github.com/kr/pty #2

carolynvs opened this issue Jul 26, 2017 · 1 comment
Assignees
@carolynvs

Comments

@carolynvs
Copy link
Collaborator

carolynvs commented Jul 26, 2017 •
edited
Loading

The godep config for github.com/kr/pty has a comment of release.r56-29-gf7ee69f which is used to create a constraint. There is no tag with that value, but there is a release.r56 tag.

We had a similar issue in dep fixed by golang/dep#869 but that won't work in this case because the tag is not a valid semver.

I doubt we wanted to pin to a specific tag anyway (that can't be updated with dep ensure -update), so I'm going to just remove it to keep rolling.

The same problem was encountered for:

  • github.com/mesos/mesos-go: before-0.26-protos-33-g45c8b08
@carolynvs carolynvs self-assigned this Jul 26, 2017
@carolynvs
Copy link
Collaborator Author

This has also been fixed by my greatest PR of all time: golang/dep#1100. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolynvs carolynvs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carolynvs