Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of a package without any code causes dep init to fail #6

Closed
carolynvs opened this issue Aug 3, 2017 · 2 comments
Closed

Import of a package without any code causes dep init to fail #6

carolynvs opened this issue Aug 3, 2017 · 2 comments

Comments

@carolynvs
Copy link
Collaborator

(14)  ? attempt github.com/chai2010/gettext-go with 1 pkgs; at least 1 versions to try
(15)      try github.com/chai2010/gettext-go@c6fed771bfd517099caf0f7a961671fa8ed08723
(15)  ✗   "github.com/chai2010/gettext-go/gettext" imports "github.com/chai2010/gettext-go", which contains malformed code: no buildable Go source files in /Users/carolynvs/go/pkg/dep/sources/https---github.com-chai2010-gettext--go

The bad import in github.com/chai2010/gettext-go was removed, but k8's is still locked to a revision where the bad import existed.

@sdboyer This was run into before, see your comment golang/dep#170 (comment), but it's not clear what the resolution should be?

@sdboyer
Copy link
Collaborator

sdboyer commented Aug 3, 2017

i think my point there was sorta that there isn't a resolution - if something is importing a package that lacks any working go code, that's a problem. we don't pull in // +build ignore'd main imports anymore, so that shouldn't be an issue.

@carolynvs
Copy link
Collaborator Author

Thanks, I'll use a later revision, where the import has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants