Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting results for CI (CircleCi) #4448

Closed
iliran11 opened this issue May 12, 2018 · 1 comment
Closed

Linting results for CI (CircleCi) #4448

iliran11 opened this issue May 12, 2018 · 1 comment

Comments

@iliran11
Copy link

iliran11 commented May 12, 2018

How is it possible to fail a CI build on CircleCi if Eslint generates an error or a warning?

Seems like the only access to linting results is through npm start.
However, this config file doesn't do the trick.

version: 2
jobs:
  build:
    docker:
      - image: circleci/node:7.10
    steps:
      - checkout
      - run: npm install
      - run: npm start

The build just hangs. I guess that start script doesn't return any exit status.

@Timer
Copy link
Contributor

Timer commented Jun 1, 2018

Change:

      - run: npm start

to:

      - run: CI=true npm run build

@Timer Timer closed this as completed Jun 1, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants