Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemaps are not working properly #494

Closed
mohsen1 opened this issue Aug 25, 2016 · 2 comments
Closed

Sourcemaps are not working properly #494

mohsen1 opened this issue Aug 25, 2016 · 2 comments

Comments

@mohsen1
Copy link

mohsen1 commented Aug 25, 2016

I just downloaded from npm (v 0.0.1) and sourcemaps are not correct:

I see this in Chrome devtools

'use strict';

Object.defineProperty(exports, "__esModule", {
  value: true
});

var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();

var _react = __webpack_require__(/*! react */ 83);

var _react2 = _interopRequireDefault(_react);

__webpack_require__(/*! ./App.css */ 256);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }

function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }

function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }

var URL = function URL() {
  _classCallCheck(this, URL);

  this.url = '';
  this.isError = false;
  this.response = {};
  this.statusCode = 200;
};
....

for my code:

import React, { Component } from 'react';
import './App.css';

class URL {
    constructor() {
        this.url = '';
        this.isError = false;
        this.response = {};
        this.statusCode = 200;
    }
}
...
@gaearon
Copy link
Contributor

gaearon commented Aug 25, 2016

Please see #139 and #343.
They are currently disabled intentionally to avoid issues with renamed variables.
When browsers start mapping sourcemap variables we will likely reconsider this.

@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

Since people seem to prefer it I merged #924.
It will enable sourcemaps and will be out in 0.8.0.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants