Lint TypeScript files

[TerribleDev]

Is this a bug report?

No

The --typescript flag does not seem to use tslint to lint the files. This seems a bit odd to me, as the javascript version ships with an eslint config.

[Timer]

Our ESLint configuration is strictly to catch errors, which TypeScript does by nature. Adding TSLint is unnecessary. If you'd like to add linting rules, you can do so in a separate linting process on commit.

[TerribleDev]

Our ESLint configuration is strictly to catch errors, which TypeScript does by nature

That's not really true, typescript does not stop you from falling through switch statements, accidentally using == instead of === or using let when you should really use const. Also, arguably allowing any types can easily cause errors which tslint can forbid.

[Timer]

Hmm, I'd be more than happy to turn on ESLint to catch some of these errors in TS files! We probably don't want to use TSLint.

Can you put together a PR?

[ianschmitz]

Our ESLint configuration is strictly to catch errors, which TypeScript does by nature

That's not really true, typescript does not stop you from falling through switch statements, accidentally using == instead of === or using let when you should really use const. Also, arguably allowing any types can easily cause errors which tslint can forbid.

To clarify, typescript does actually support catching falling through switch statements by enabling noFallthroughCasesInSwitch, however i do agree with the rest of what you've said :)

[TerribleDev]

@Timer how can eslint scan ts files? AFAIK it can't parse the ts syntax (although I could be mistaken). Also there are ts specific properties you want to catch such as forbidding any

[Timer]

Forbidding any is a style rule we won't support.

Also, you can use typescript-eslint-parser: https://github.com/eslint/typescript-eslint-parser

[TerribleDev]

@Timer Fair enough

[Timer]

Created #5641 to track. Let's go with TSLint.