New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc link in serviceWorker.js is out of date - https://bitly.com/CRA-PWA #7310

Closed

pimlottc-gov opened this issue Jul 2, 2019 · 1 comment

Labels

pimlottc-gov commented Jul 2, 2019

Describe the bug

The documentation link in the serviceWorkers.js file generated by create-react-app is out of date:

https://bit.ly/CRA-PWA

The link redirects to:
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#making-a-progressive-web-app

This page does not contain any information about service workers / progressive web apps.

It seems like the new correct page should be:
https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app.

Steps to reproduce

npx create-react-app my-app
Examine my-app/src/serviceWorkers.js
Open the link in the comments

Expected behavior

User sees documentation on register a service worker.

Actual behavior

User sees default create-react-app README.md template.

pimlottc-gov added the issue: bug label

Contributor

petetnt commented Jul 2, 2019

Thanks @pimlottc-gov, this is a dupe of #5910

petetnt closed this as completed

lock bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.