Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation with version and sub-directories fails #1140

Closed
t00f opened this issue Dec 4, 2018 · 7 comments
Closed

Compilation with version and sub-directories fails #1140

t00f opened this issue Dec 4, 2018 · 7 comments
Assignees
Labels
bug An error in the Docusaurus core causing instability or issues with its execution status: needs more information There is not enough information to take action on the issue.

Comments

@t00f
Copy link

t00f commented Dec 4, 2018

🐛 Bug Report

Recently @yangshun fixed an issue in the generation of the sidebar.json (See #1124)
However, I am now facing an issue when trying to compile a project with multiple version.

When compiling, it complains about the document id:

Error: Document id cannot include "/".

Have you read the Contributing Guidelines on issues?

No

To Reproduce

  1. Create a docs within a subdirectory. In my case: docs/main/features/delegating-permissions
---
title: Delegating Permissions
id: delegating-permissions
---
# Some content
  1. Create a version 0.0.1 using yarn run version 0.0.1
  2. See the following generated file in website. In my case: website/versioned_docs/version-0.0.1/main/features
---
title: Delegating Permissions
id: version-0.0.1-main/features/delegating-permissions
original_id: main/features/delegating-permissions
---
# Some content
  1. Compile the project. It fails with the issue described above:
% yarn run build
yarn run v1.12.1
warning package.json: No license field
$ docusaurus-build
Error: Document id cannot include "/".

Expected behavior

The build should pass without error and the website should be able to render.

Actual Behavior

Build is failing with error Error: Document id cannot include "/".

@endiliey
Copy link
Contributor

endiliey commented Dec 4, 2018

Are you on 1.6.0 ? Could be a regression from #1125

@endiliey endiliey self-assigned this Dec 4, 2018
@endiliey endiliey added bug An error in the Docusaurus core causing instability or issues with its execution status: needs more information There is not enough information to take action on the issue. labels Dec 4, 2018
@t00f
Copy link
Author

t00f commented Dec 4, 2018

@endiliey yes I upgraded to 1.6.0

@endiliey
Copy link
Contributor

endiliey commented Dec 4, 2018

Fixed this in a commit cb1395e

Will release 1.6.1 as hotfix soon probably in couple of days (im currently away from keyboard, relying on mobile phone to merge & commit)

@t00f
Copy link
Author

t00f commented Dec 4, 2018

Thanks for the quick reply. Looking forward to 1.6.1!

@aeneasr
Copy link
Contributor

aeneasr commented Dec 7, 2018

Thank you for the fix! Would it be possible to release this? My doc toolchain is completely broken because of this :(

@endiliey
Copy link
Contributor

endiliey commented Dec 7, 2018

Just published v1.6.1

Sorry for the wait ! 😄

@aeneasr
Copy link
Contributor

aeneasr commented Dec 7, 2018

Awesome, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution status: needs more information There is not enough information to take action on the issue.
Projects
None yet
Development

No branches or pull requests

3 participants