Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check links before starting the site #210

Closed
JoelMarcey opened this issue Nov 1, 2017 · 7 comments · May be fixed by rmkanda/docusaurus#9
Closed

Check links before starting the site #210

JoelMarcey opened this issue Nov 1, 2017 · 7 comments · May be fixed by rmkanda/docusaurus#9
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@JoelMarcey
Copy link
Contributor

Can we have it where if links are known to be bad, that when you run yarn start to run a site, it fails with a bad links message?
@JoelMarcey
Copy link
Contributor Author

JoelMarcey commented Dec 18, 2017 •
edited
Loading

Maybe textlint and friends described in #302 could fix this?

@azu
Copy link
Contributor

azu commented Dec 18, 2017

Probably, correct link is #302

@JoelMarcey
Copy link
Contributor Author

Oh right. Nice catch. I updated my comment :)

@JoelMarcey JoelMarcey added the feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. label Feb 27, 2018
@endiliey endiliey added the good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. label Jun 2, 2018
@endiliey
Copy link
Contributor

I think linting should be done via user side. It's not nice to crawl & check for external link.

@JoelMarcey
Copy link
Contributor Author

Not saying we shouldn't close this necessarily -- but I think this was in reference to internal links within the docs. To make sure we didn't type anything bad in xxx or something.

@endiliey
Copy link
Contributor

I think i missed that. We could file a new issue if needed 😊. Old issue like this usually isnt seen by contributor, so new issue can kinda bump things up

@JoelMarcey
Copy link
Contributor Author

Sure. Let's file a new issue.

@snyk-bot snyk-bot mentioned this issue May 26, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jan 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade jscodeshift from 0.11.0 to 0.12.0 rmkanda/docusaurus
3 participants
@azu @JoelMarcey @endiliey