Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error boundaries #2889

Closed
slorber opened this issue Jun 5, 2020 · 1 comment · Fixed by #3104
Closed

Error boundaries #2889

slorber opened this issue Jun 5, 2020 · 1 comment · Fixed by #3104
Labels
difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future.

Comments

@slorber
Copy link
Collaborator

slorber commented Jun 5, 2020

💥 Proposal

There's no getDerivedStateFromError or componentDidCatch in Docusaurus v2.

Errors might not happen very often, particularly most of them would simple make the build fail.

But it might still be useful to add a default global error boundary in case the code of the user produces a runtime error. Some people might introduce buggy code in pages that might crash at runtime.
@slorber slorber added difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. proposal This issue is a proposal, usually non-trivial change v2 pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Jun 5, 2020
@spyke01
Copy link
Contributor

spyke01 commented Jul 23, 2020

I'll take a look into this.

@spyke01 spyke01 mentioned this issue Jul 23, 2020
Merged
@Josh-Cena Josh-Cena added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. and removed v2 pr: polish This PR adds a very minor behavior improvement that users will enjoy. proposal This issue is a proposal, usually non-trivial change labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): Add React ErrorBoundary component + theme default boundaries spyke01/docusaurus
3 participants
@slorber @spyke01 @Josh-Cena