Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect include paths at build time #25

Closed
BenPope opened this issue Mar 18, 2013 · 0 comments
Closed

Incorrect include paths at build time #25

BenPope opened this issue Mar 18, 2013 · 0 comments

Comments

@BenPope
Copy link

BenPope commented Mar 18, 2013

configure.ac has an incorrect build path:

AC_SUBST(AM_CPPFLAGS, '-I../$(top_srcdir)'" "'-I$(top_srcdir)/io'" "'-I$(top_srcdir)/test'" -lstdc++ $CXX_FLAGS $BOOST_CPPFLAGS")

Should be:

AC_SUBST(AM_CPPFLAGS, '-I$(top_srcdir)/..'" "'-I$(top_srcdir)/io'" "'-I$(top_srcdir)/test'" -lstdc++ $CXX_FLAGS $BOOST_CPPFLAGS")
@jdelong jdelong closed this as completed Apr 13, 2013
@tian-yuan tian-yuan mentioned this issue Jul 23, 2016
Closed
@tdauth tdauth mentioned this issue Mar 3, 2017
Closed
@D-PorcoRosso D-PorcoRosso mentioned this issue Aug 29, 2017
Closed
facebook-github-bot pushed a commit that referenced this issue Jul 10, 2020
@lukaspiatkowski @facebook-github-bot
edenscm/hg: add GitHub Actions with CI for HG plus add fixes for getd…
e9a34c0 
…eps (#25)

Summary:
Fixes include:
1. Passing "GETDEPS_BUILD_DIR" and "GETDEPS_INSTALL_DIR" env variable and using them in eden/scm/Makefile rather than assuming the source code is always in the same place regardless getdeps arguments (it isn't).
2. Added "fbthrift-source" and "fb303-source" to avoid unnecessary compilation (at least of fb303) and to put fbthrift and fb303 source code in an easy to locate place inside getdeps' "installed" folder.

Pull Request resolved: facebook/sapling#25

Test Plan: sandcastle, check oss-eden_scm-darwin-getdeps

Reviewed By: farnz

Differential Revision: D22431872

Pulled By: lukaspiatkowski

fbshipit-source-id: 8ccbb090713ec085a5dd56df509eb58ab6fb9e34
dotconnor pushed a commit to 5448C8/folly that referenced this issue Mar 19, 2021
@lukaspiatkowski @dotconnor
edenscm/hg: add GitHub Actions with CI for HG plus add fixes for getd…
7cfdd01 
…eps (facebook#25)

Summary:
Fixes include:
1. Passing "GETDEPS_BUILD_DIR" and "GETDEPS_INSTALL_DIR" env variable and using them in eden/scm/Makefile rather than assuming the source code is always in the same place regardless getdeps arguments (it isn't).
2. Added "fbthrift-source" and "fb303-source" to avoid unnecessary compilation (at least of fb303) and to put fbthrift and fb303 source code in an easy to locate place inside getdeps' "installed" folder.

Pull Request resolved: facebook/sapling#25

Test Plan: sandcastle, check oss-eden_scm-darwin-getdeps

Reviewed By: farnz

Differential Revision: D22431872

Pulled By: lukaspiatkowski

fbshipit-source-id: 8ccbb090713ec085a5dd56df509eb58ab6fb9e34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenPope @jdelong