Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make failed in Ubuntu 16.04.1 #453

Closed
ehzawad opened this issue Aug 13, 2016 · 7 comments
Closed

Make failed in Ubuntu 16.04.1 #453

ehzawad opened this issue Aug 13, 2016 · 7 comments

Comments

@ehzawad
Copy link

ehzawad commented Aug 13, 2016

What the hell is this?

Tried three times... same error
hell

@adlawren
Copy link

adlawren commented Aug 15, 2016

Seems like the changes applied in this commit caused the issue? At least on my PC, reseting to the commit before that commit results in a successful build. Afterwards, introducing the include statement added in the commit seems to cause the build failure.

Very perplexing...

@ehzawad
Copy link
Author

ehzawad commented Aug 15, 2016

Folly community should update readme for ubuntu 16.04 LTS.. because it is one of the major OSs developers use. al least for noob people.... very perplexing :/

@lukenels
Copy link

Could you see if applying this patch to folly fixes your build errors? I'm not sure if this will fix it in all cases, but it appears to have fixed the build on my Ubuntu VM. Thanks!

@lukenels
Copy link

Existing PR with solution to this problem at #455.

@ehzawad
Copy link
Author

ehzawad commented Aug 23, 2016

Thank you @lukenels .. I am checking right now

@ehzawad
Copy link
Author

ehzawad commented Aug 23, 2016

#440
I am getting range_test error.. :\

I am using ubuntu in vmware workstation @lukenels

@adlawren
Copy link

adlawren commented Aug 23, 2016

@lukenels Verified that compilation was successful using Ubuntu 16.04 64-bit after introducing the include added in that diff.

@ehzShelter I'm not sure if the test failure is related; it might be, but from what I recall there were some tests failing before I saw this issue.

@ehzawad ehzawad closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants