From 9ec2f12b9902d4277e0e9b62a77f6475fccc77c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Szab=C3=B3?= Date: Wed, 31 Jul 2024 17:15:41 +0200 Subject: [PATCH] Add fbcode_builder manifests for mcrouter and ragel https://github.com/facebook/mcrouter currently uses a legacy autotools-based build system, which forces third parties to rely on a collection of scripts hosted in the repository to build it with all required dependencies. This is brittle and has lead to many issue reports with build issues. In https://github.com/facebook/mcrouter/pull/449, I've prepared a working CMake-based build system for mcrouter that could replace the legacy autotools setup. This patch adds the necessary manifests for mcrouter and its ragel dependency so that fbcode_builder itself will be setup for the repo without the PR having to do it. --- build/fbcode_builder/manifests/mcrouter | 23 +++++++++++++++++++++++ build/fbcode_builder/manifests/ragel | 19 +++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 build/fbcode_builder/manifests/mcrouter create mode 100644 build/fbcode_builder/manifests/ragel diff --git a/build/fbcode_builder/manifests/mcrouter b/build/fbcode_builder/manifests/mcrouter new file mode 100644 index 00000000000..849e8f75d10 --- /dev/null +++ b/build/fbcode_builder/manifests/mcrouter @@ -0,0 +1,23 @@ +[manifest] +name = mcrouter + +[git] +repo_url = https://github.com/facebook/mcrouter.git + +[dependencies] +folly +wangle +fizz +fbthrift +mvfst +ragel + +[build] +builder = cmake +subdir = . + +[cmake.defines.test=on] +BUILD_TESTS=ON + +[cmake.defines.test=off] +BUILD_TESTS=OFF diff --git a/build/fbcode_builder/manifests/ragel b/build/fbcode_builder/manifests/ragel new file mode 100644 index 00000000000..336a39b20ff --- /dev/null +++ b/build/fbcode_builder/manifests/ragel @@ -0,0 +1,19 @@ +[manifest] +name = ragel + +[debs] +ragel + +[homebrew] +ragel + +[rpms] +ragel + +[download] +url = https://www.colm.net/files/ragel/ragel-6.10.tar.gz +sha256 = 5f156edb65d20b856d638dd9ee2dfb43285914d9aa2b6ec779dac0270cd56c3f + +[build] +builder = autoconf +subdir = ragel-6.10