-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async arrow functions are not supported, making 'show source' unusable inside them #1208
Comments
Thanks for the report. Hermes doesn't support e.g. if your babel set up lowers to generators, you'd get this output. Notice that This will be fixed when we add support for EDIT: When I say Hermes doesn't support |
Reclassifying as enhancement, since technically the solution to this is to implement async arrow functions. |
@tmikov When is a fix expected? That is, using async in regular functions (not arrows) will work? |
@KonstantinZhukovskij async functions have been supported by Hermes for years. Only async arrow functions are not implemented. However I don't know how React Native configures Babel. |
Thanks for your reply @tmikov. Could you please provide an example of how I can use the functions? Because indeed, any functions (both ordinary and arrow) turn into generators and the directive no longer works there. |
Hi @dzengi, our strong recommendation is that converting a running function to source code, especially in the presence of Babel transformations, is almost never a good idea. You are much better off just copying the function into a string manually. If you really need to do it, you need to look into how React Native configures Babel plugins in Metro. Unfortunately our team does't have much expertise in either Babel or Metro, so take this with a grain of salt and ideally confirm with someone who understands Babel and Metro: Hermes does not currently support async arrow functions and
This has not been tested by us. The good news is that we will be releasing a beta version of Hermes supporting most ES6+ features in 2024 Q1, so at that time none of these plugins will be necessary. Hope this helps! |
Has anyone figured out how to configure plug-ins, to support async arrow functions while Hermes does not yet do so? Would really love to know how to do this. |
Static Hermes supports async arrow functions. Before it is released as default, it can be tried from this repository: https://github.com/software-mansion-labs/hermes |
I'm using the
'show source'
directive, however it only works with synchronous functions. With asynchronous ones, I still only see bytecode. Android/iOS the same."react": "18.2.0",
"react-native": "0.72.7",
"react-native-webview": "13.6.3"
The text was updated successfully, but these errors were encountered: