Add a trailing slash to the root pattern (#5464)

jestjs · Feb 5, 2018 · af09be8 · af09be8
1 parent a24204a
commit af09be8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/packages/jest-cli/src/__tests__/search_source.test.js b/packages/jest-cli/src/__tests__/search_source.test.js
@@ -463,5 +463,24 @@ describe('SearchSource', () => {
         path.join(rootDir, '__testtests__', 'test.jsx'),
       ]);
     });
+
+    it('does not mistake roots folders with prefix names', async () => {
+      const config = normalize(
+        {
+          name,
+          rootDir: '.',
+          roots: ['/foo/bar/prefix'],
+        },
+        {},
+      ).options;
+
+      searchSource = new SearchSource(
+        await Runtime.createContext(config, {maxWorkers}),
+      );
+
+      const input = ['/foo/bar/prefix-suffix/__tests__/my-test.test.js'];
+      const data = searchSource.findTestsByPaths(input);
+      expect(data.tests).toEqual([]);
+    });
   });
 });
diff --git a/packages/jest-cli/src/search_source.js b/packages/jest-cli/src/search_source.js
@@ -78,7 +78,7 @@ export default class SearchSource {
     const {config} = context;
     this._context = context;
     this._rootPattern = new RegExp(
-      config.roots.map(dir => escapePathForRegex(dir)).join('|'),
+      config.roots.map(dir => escapePathForRegex(dir + path.sep)).join('|'),
     );
 
     const ignorePattern = config.testPathIgnorePatterns;