Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest throws when using an old global CLI #105

Closed
sophiebits opened this issue Aug 4, 2014 · 3 comments
Closed

Jest throws when using an old global CLI #105

sophiebits opened this issue Aug 4, 2014 · 3 comments

Comments

@sophiebits
Copy link
Contributor

Old globally-versions of jest installed globally don't pass the onComplete handler to runCLI so they error at the end of a test run when Q tries to call the handler (I think). We should either make the onComplete handler optional or maybe rename runCLI to runCLIAsync and have runCLI throw an informative error. (Also maybe try to make the global script even smarter/dumber so it doesn't rely on such API details? Not sure how simple that is.)

@jeffmo
Copy link
Contributor

jeffmo commented Aug 4, 2014

Good catch. We should've caught this when updating that API -- at the very least we should add a comment specifying that changes to that API need to be backward compatible (or need to be a breaking version change).

I'm ok with making onComplete optional for now

@jeffmo
Copy link
Contributor

jeffmo commented Aug 5, 2014

Just published 0.1.18 with a fix that gives onComplete a default function value if it wasn't provided by the caller

@jeffmo jeffmo closed this as completed Aug 5, 2014
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants