Fix Node.js 4 support with Proxy

[ai]

Summary

Because many projects must support Node.js 4 until LTS end (August 2018) we decided for silent support of Node.js. For example, big projects like Autoprefixer and PostCSS must support Node.js 4, so we run tests on Travis CI with Node.js 4.

Proxy is used for a small win32 fix. Maybe it could be fixed even without Proxy, but I made a small if to be clean.

Test plan

Since it is silent support of Node.js 4 I didn’t add tests.

[ai]

Right now Browserslist 3.0 release is blocked by this issue. Babel 7 needs Browserslist 3.0 too :). “global village” :D.

[mjesun]

real is an empty object here, since it's just created based on the prototype. A better fix would be to do, just after the signature of the method:

if (typeof Proxy === 'undefined') {
  return deepCyclicCopy(process.env);
}

[ai]

Sure. Wait a second. Do you have some deepCyclicCopy method already in the project?

[codecov-io]

Codecov Report

Merging #5489 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5489   +/-   ##
=======================================
  Coverage   61.66%   61.66%           
=======================================
  Files         213      213           
  Lines        7069     7069           
  Branches        3        4    +1     
=======================================
  Hits         4359     4359           
  Misses       2709     2709           
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-util/src/create_process_object.js	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9797f23...9191b79. Read the comment docs.

[ai]

@mjesun done

[mjesun]

Cool, but you can discard the other commit 😉

[ai]

@mjesun I merged commits (you can do the same with “Squash me Merge” option on GitHub pull requests).

[mjesun]

What i meant is that you just need the three lines I added in the review; the rest can be removed 🙂

[ai]

@mjesun :D cleaned up

[mjesun]

@thymikee ... and the tar bug again :(

[ai]

Thanks :). Waiting for release =^_^=.

[ai]

@mjesun could you please release it. Browserslist is still broken.

[SimenB]

Needs #5496 before release

[ai]

@SimenB #5496 was merged :) (Autoprefixer release is blocked by this issue too)

[jdalton]

Thanks @ai!

@SimenB Can this package be bumped sooner than later to fix the Node 4 compat regression?

[SimenB]

I don't have publish access on npm, so either @mjesun or @cpojer has to do it (or some other FB employee)

[ai]

@mjesun @cpojer Browserslist 3.0 and Autoprefixer released is blocked 😣. We need it really soon

[mjesun]

Let me do a patch with the current status :)

[mjesun]

22.2.2 is out!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.