Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverageProvider to jest --init #10044

Closed

Conversation

mohamedsgap
Copy link
Contributor

Created This PR to resolve this issue #10015, to add 'coverageProvider' to 'jest --init' prompts

Summary

We need to encourage folks try out the V8 based code coverage, so the prompt in "--init" and its entry into the generated config file would be help.

@facebook-github-bot
Copy link
Contributor

Hi @mohamedsgap!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented May 15, 2020

Thanks! Could you add some tests as well? And an entry in the changelog 🙂

@mohamedsgap
Copy link
Contributor Author

hey @SimenB, just updated this PR with some tests and add entry to changelog, buy i don't know that some checks did't pass!
Screenshot from 2020-05-16 22-38-37

@jeysal
Copy link
Contributor

jeysal commented May 24, 2020

Hi @mohamedsgap , you also need to modify some things in jest-cli/src/init - that's where what prompts returns is analyzed and a config is created from it 🙃

@mohamedsgap mohamedsgap changed the title [WIP] Add coverageProvider to jest --init prompts Add coverageProvider to jest --init prompts May 28, 2020
@SimenB
Copy link
Member

SimenB commented May 29, 2020

There's a failing test, mind taking a look?

@mohamedsgap mohamedsgap changed the title Add coverageProvider to jest --init prompts Add coverageProvider to jest --init May 31, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants