fix(expect): objectContaining should recurse into sub-objects
#10508
Conversation
|
Hi @ioancole! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
2 similar comments
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Ergh, seems CI is unhappy 😅 Would you be able to take a look? |
|
Hey Simen, thanks for looking at this so quickly. The only check failing now is the windows-latest test run on a seemingly completely unrelated DOM test, and this check passed on a previous push to this PR. Is there a way to re-run the CI pipeline? I think this will pass on a re-run. Thanks! |
|
Yeah, that failure looks like flake. I'll retrigger CI 👍 |
|
@ioancole sorry, this seems to produce a type error. Could you take a look? |
|
Hey! It's fixed now. Thanks again |
SimenB
changed the title
objectContaining should recurse into sub-objects
|
Thanks @ioancole! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Addressing bug report #10462. According to the docs,
objectContainingshould apply in a recursive sense, however it doesn't seem to do this currently.Summary
This change will make
objectContainingwork recursively into sub-objects.Test plan
Included a unit test for the new behavior, and confirmed that all older tests still pass.