Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fake-timers): don't setup fakeTimerAPIs unless needed #10551

Conversation

tgriesser
Copy link
Contributor

@tgriesser tgriesser commented Sep 23, 2020

Summary

Noticed that the mock fn's for the legacy fake timers are created immediately, even if they're never used. Since _createMocks is called in useFakeTimers, it seems we should be able to remove this from the constructor and only set them up if needed.

Test plan

No functional change, existing tests should pass

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind adding a changelog entry?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants