Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support named exports from CJS as named ESM imports #10673

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 21, 2020

Summary

See #9430 (comment)

Test plan

Test added

@SimenB SimenB mentioned this pull request Oct 21, 2020
21 tasks
let cjsExports: ReadonlyArray<string> = [];

if (transformedCode) {
const {exports} = parseCjs(transformedCode.code);
Copy link
Member Author

@SimenB SimenB Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ignore re-exports - I'm not sure what the semantics are? Where would I get the "value" from?

EDIT: I guess we could resolve the resulting path? Again, not sure what the value would be

@@ -18,6 +18,8 @@ import {
Module as VMModule,
} from 'vm';
import * as nativeModule from 'module';
// @ts-expect-error
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB SimenB merged commit 374fe52 into jestjs:master Oct 23, 2020
@SimenB SimenB deleted the named-cjs-import branch October 23, 2020 07:41
This was referenced Oct 26, 2020
This was referenced Mar 12, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants