Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove support for runScript #11155

Merged
merged 10 commits into from
Mar 7, 2021
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 5, 2021

Summary

It cannot be used for ESM anyways, so let's clean up our code a bit

Test plan

Green CI

@@ -142,6 +142,13 @@ async function runTestInternal(
docblockPragmas,
testPath: path,
});

if (typeof environment.getVmContext !== 'function') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we warn if runScript is present? Might make it harder for a single test env to support multiple versions of Jest, bt also less confusing than "why isn't my code running"

packages/jest-runner/src/runTest.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #11155 (a999062) into master (fedafc3) will increase coverage by 0.02%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11155      +/-   ##
==========================================
+ Coverage   64.19%   64.21%   +0.02%     
==========================================
  Files         307      307              
  Lines       13372    13369       -3     
  Branches     3260     3258       -2     
==========================================
+ Hits         8584     8585       +1     
+ Misses       4083     4081       -2     
+ Partials      705      703       -2     
Impacted Files Coverage Δ
packages/jest-environment-node/src/index.ts 61.11% <ø> (+4.70%) ⬆️
packages/jest-runner/src/runTest.ts 1.92% <0.00%> (-0.12%) ⬇️
packages/jest-runtime/src/index.ts 55.76% <66.66%> (+0.17%) ⬆️
packages/jest-environment-jsdom/src/index.ts 39.13% <100.00%> (+1.13%) ⬆️
packages/expect/src/utils.ts 96.12% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedafc3...a999062. Read the comment docs.

@SimenB
Copy link
Member Author

SimenB commented Mar 6, 2021

Will merge after we land the website update

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants