fix(env-jsdom): remove setImmediate and clearImmediate

[SimenB]

Summary

Fixes #11204

Test plan

Green CI

[SimenB]

Bah, this fails since source-map-support requires Buffer... Gonna be somewhat painful this 😛

[SimenB]

It was impossible to see where errors originated without this

Before:

After:

[SimenB]

let's not have that now though to reduce the surface of this PR

[ahnpnl]

Oh wow I ran into that reference error yesterday for some reasons and it was gone out of the blue

[SimenB]

This breaks @testing-library/dom: testing-library/dom-testing-library#914

[SimenB]

for some reason this is horribly slow:

If I comment out the install call (but keeping the require):

Note that the install itself is fast, it's whatever happens when something throws later that that takes 10+ seconds...

[SimenB]

@LinusU any ideas about what's happening here? I'm having some issues reproducing this using plain JSDOM, so I'm not really sure where to begin debugging this...

[SimenB]

Might land removal of {set,clear}Immediate and leave Buffer in for now if the source map stuff proves elusive. Regardless we need to wait for (or patch locally, which is meh) for @testing-library/dom to handle the timer functions missing, so no need to decide right now

[gaearon]

Does testing-library/dom-testing-library#916 unblock you?

[SimenB]

Yep, it does! 👍

If it's merged and released I'll just keep the Buffer change separate until we figure out why it makes that test so horribly slow.

Alternatively I can just use yarn patch, but hopefully that PR lands soonish so we don't need such workarounds

[renatoalencar]

Hi @SimenB, I added the following test case in order to reproduce the issue. Let me know if that covers it.

  test('safe check for setImmediate and clearImmediate', () => {
    const setImeediate = global.setImmediate
    const clearImmediate = global.clearImmediate
    delete global.setImmediate
    delete global.clearImmediate

    expect(() => runWithRealTimers(() => {})).not.toThrow()

    global.setImmediate = setImeediate
    global.clearImmediate = clearImmediate
  })

[renatoalencar]

Hi @SimenB, I added the following test case in order to reproduce the issue. Let me know if that covers it.

  test('safe check for setImmediate and clearImmediate', () => {
    const setImeediate = global.setImmediate
    const clearImmediate = global.clearImmediate
    delete global.setImmediate
    delete global.clearImmediate

    expect(() => runWithRealTimers(() => {})).not.toThrow()

    global.setImmediate = setImeediate
    global.clearImmediate = clearImmediate
  })

From the tests I've made it throws the same exception.

[gaearon]

@renatoalencar I don't understand what line is pictured on your screenshot. It shouldn't exist after your change, should it? setImmediate is no longer listed in that object unconditionally.

[renatoalencar]

@renatoalencar I don't understand what line is pictured on your screenshot. It shouldn't exist after your change, should it? setImmediate is no longer listed in that object unconditionally.

Yeah, I just putted it there so I could reproduce the error through the tests. I wanted to see if that would happen by just deleting setImmediate and clearTimeout from the global object and calling runWithRealTimers.

I wrote the tests after the code, so I'm just showing that they really cover this case.

[gaearon]

Ahh got it.

[SimenB]

Following up on Buffer here: #11241

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.