-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resolver): support node prefix from ESM #11817
Conversation
2e8ed0f
to
1366811
Compare
b0e5b39
to
3cd0076
Compare
Codecov Report
@@ Coverage Diff @@
## master #11817 +/- ##
==========================================
- Coverage 69.04% 68.94% -0.11%
==========================================
Files 312 312
Lines 16366 16400 +34
Branches 4746 4750 +4
==========================================
+ Hits 11300 11307 +7
- Misses 5039 5066 +27
Partials 27 27
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
See #11802 (comment)
Underlying issue is
resolve
only supportrequire
(thusnode:
only works for node 16) - this skips callingresolve
at all if we think it's a core module on our sideTest plan
e2e test added