-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(message-utils): convert URLs to paths #12277
Conversation
Hi @mshima! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #12277 +/- ##
==========================================
- Coverage 67.53% 67.53% -0.01%
==========================================
Files 328 328
Lines 17239 17241 +2
Branches 5064 5065 +1
==========================================
+ Hits 11642 11643 +1
- Misses 5564 5565 +1
Partials 33 33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This needs a test and a changelog entry 🙂
6fb5556
to
e983f90
Compare
Workaround for tapjs/stack-utils#60
@SimenB thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Wait, it's failing on Windows |
Windows still unhappy 😞 |
Thank you! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Workaround for tapjs/stack-utils#60
toMatchInlineSnapshot
with mjs files causes the following error:Inspired by microsoft/playwright#10043.
Test plan