Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest-runtime): calling jest.resetModules function will clear FS and transform cache #12531

Merged
merged 4 commits into from
Mar 2, 2022
Merged

feat(jest-runtime): calling jest.resetModules function will clear FS and transform cache #12531

merged 4 commits into from
Mar 2, 2022

Conversation

TrickyPi
Copy link
Contributor

@TrickyPi TrickyPi commented Mar 2, 2022

Summary

close #12106

Test plan

add specific tests

@TrickyPi TrickyPi changed the title feat: clear require cache feat(jest-runtime): calling jest.resetModules function will clear require cache Mar 2, 2022
SimenB
SimenB requested changes Mar 2, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! just some nits 🙂

packages/jest-runtime/src/index.ts Show resolved Hide resolved
e2e/__tests__/clearRequireCache.test.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@TrickyPi TrickyPi changed the title feat(jest-runtime): calling jest.resetModules function will clear require cache feat(jest-runtime): calling jest.resetModules function will clear FS and transform cache Mar 2, 2022
SimenB
SimenB approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@TrickyPi
Copy link
Contributor Author

TrickyPi commented Mar 2, 2022

thanks for your review and help.

@SimenB SimenB merged commit 85a123f into jestjs:main Mar 2, 2022
@TrickyPi TrickyPi deleted the feat-12106 branch March 2, 2022 10:03
@github-actions
Copy link

github-actions bot commented Apr 2, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: failed to clear require cache
3 participants
@TrickyPi @SimenB @facebook-github-bot