Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-environment-node): Add structuredClone to globals #12631

Merged
merged 4 commits into from
Apr 4, 2022
Merged

fix(jest-environment-node): Add structuredClone to globals #12631

merged 4 commits into from
Apr 4, 2022

Conversation

Araxeus
Copy link
Contributor

@Araxeus Araxeus commented Apr 4, 2022

Summary

Fix #12628

structuredClone is available from version 17, see:

Test plan

tested locally.

@facebook-github-bot
Copy link
Contributor

Hi @Araxeus!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! as soon as the CLA is signed we can merge this 🙂

EDIT: hah, what a timing 😀

@Araxeus
Copy link
Contributor Author

Araxeus commented Apr 4, 2022

sorry I only tested it as js and forgot about the missing type

might wanna wait for DefinitelyTyped/DefinitelyTyped#59434 or implement that interface locally?

@SimenB
Copy link
Member

SimenB commented Apr 4, 2022

just add @ts-expect-error and it'll be cleaned up when we update our types 🙂

@Araxeus Araxeus requested a review from SimenB April 4, 2022 18:47
@SimenB SimenB changed the title fix(jest-environment-node): Add structuredClone to globals fix(jest-environment-node): Add structuredClone to globals Apr 4, 2022
@SimenB SimenB merged commit c7b1538 into jestjs:main Apr 4, 2022
@SimenB
Copy link
Member

SimenB commented Apr 5, 2022

@github-actions
Copy link

github-actions bot commented May 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: structuredClone is not defined
3 participants