fix(jest-haste-map): Make watchman existence check lazy+async #12675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
jest-haste-map
checks for watchman existence at import time (top level) with a blockingexecSync
call. This has a few downsidesexecSync
spawns a shell, which isn't necessary here -execFile
is more efficient.useWatchman: false
.This PR extracts this to an async utility function, executed lazily and memoized by the core class.
Test plan
New unit tests cover
lib/isWatchmanInstalled.ts
and lazy executionBehaviour of
execFile
when watchman is installed: