Refactor runner #3166
Merged
Refactor runner #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogeliog
approved these changes
Mar 17, 2017
| const timing = cache[filePath] && cache[filePath][1]; | ||
| if (timing) { | ||
| timings.push(timing); | ||
| tests.forEach(test => { |
There was a problem hiding this comment.
Just a minor nit, but I think we can change this for
const timings = tests.map(test => test.duration).filter(duration => !!duration)There was a problem hiding this comment.
Glad you are bringing this up! I actually can't simplify because flow isn't smart enough to realize that the filter call filters out falsy values. It types timings as Array<?number> instead of Array<number> :(
There was a problem hiding this comment.
Got it, that is interesting
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Improve runJest by breaking up the promise chain into functions. * Use async/await. * Add a TestSequencer and “Test” type to clarify responsibilities and improve type interfaces. * async/await in runTests. * Minor cleanups * Fix the test. * Move `runCLI` into the cli folder. * Updates to TestSequencer + test the code.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Improve runJest by breaking up the promise chain into functions. * Use async/await. * Add a TestSequencer and “Test” type to clarify responsibilities and improve type interfaces. * async/await in runTests. * Minor cleanups * Fix the test. * Move `runCLI` into the cli folder. * Updates to TestSequencer + test the code.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the preparatory work I did for the multi-config runner. It splits up the test performance cache into a TestSequencer class, uses async/await and moves a few things around. No behavior changes expected. Before merging, I will add a test for the TestSequencer.
See #3156
Test plan
jest