Add support for Babel 7 in babel-jest #3271
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #3271 +/- ##
=======================================
Coverage 64.24% 64.24%
=======================================
Files 175 175
Lines 6436 6436
Branches 4 4
=======================================
Hits 4135 4135
Misses 2300 2300
Partials 1 1Continue to review full report at Codecov.
|
* Add support for Babel 7 in babel-jest * Fix Flow enforcing string literals on require() * Update index.js
* Add support for Babel 7 in babel-jest * Fix Flow enforcing string literals on require() * Update index.js
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Adds support for Babel 7:
.babelrc.jsfilebabel.util(no need for it, apparently)Test plan
I've tested this locally and it works well. The changes are pretty minimal.
The question I have is why was the
canCompilecall there in the first place? Here's the PR to Babel that removed the util: babel/babel#5487. It recommends simply calling.transforminstead (which is currently being done anyway.