ESlint: Handle modifiers on expect in valid-expect

[SimenB]

Summary
Part 1 of #3082 split up, see that for justification. I'll send a PR for locations soon™️

Test plan
See added tests which failed before this change

[SimenB]

/cc @jkimbo

[SimenB]

I'm not good enough at Flow to resolve the type error... Too bad eslint does not have an official flow typing.

Error:

packages/eslint-plugin-jest/src/rules/valid-expect.js:49
 49:               propertyName = node.parent.parent.property.name;
                                                     ^^^^^^^^ property `property`. Property not found in
 49:               propertyName = node.parent.parent.property.name;
                                  ^^^^^^^^^^^^^^^^^^ object type


Found 1 error

[SimenB]

Seg fault now, I don't think that's on me, though...

[wyze]

From what I can tell, the Flow error is because the CallExpression type doesn't contain a key for property.

We just need to refine the type to be more specific.

           let propertyName = node.parent.property.name;
-          let grandParentType = node.parent.parent.type;
+          let grandParent = node.parent.parent;
  
            // a property is accessed, get the next node
            if (grandParent.type === 'MemberExpression') {
              // a modifier is used, just get the next one
              if (expectProperties.indexOf(propertyName) > -1) {
-               /* $FlowFixMe */
-               propertyName = node.parent.parent.property.name;
-               grandParentType = node.parent.parent.parent.type;
+               propertyName = grandParent.property.name;
+               grandParent = grandParent.parent;
              } else {
                // only a few properties are allowed
                context.report({
                  message: `"${propertyName}" is not a valid property of expect.`,
                  node,
                });
              }
            }
  
            // matcher was not called
-           if (grandParentType === 'ExpressionStatement') {
+           if (grandParent.type === 'ExpressionStatement') {
              context.report({
                message: `"${propertyName}" was not called.`,
                node,
              });
            }

[SimenB]

@wyze Thank you, I could remove the suppression now!
TBH I don't get why that should matter (I tried doing const grandparent: MemberExpression = node.parent.parent; inside the if, but that made it complain more).
I suppose it's unable to infer based on the .type check what type it really is.

[codecov-io]

Codecov Report

Merging #3306 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3306      +/-   ##
==========================================
+ Coverage    63.9%   63.95%   +0.05%     
==========================================
  Files         176      176              
  Lines        6475     6484       +9     
  Branches        4        4              
==========================================
+ Hits         4138     4147       +9     
  Misses       2336     2336              
  Partials        1        1

Impacted Files	Coverage Δ
...kages/eslint-plugin-jest/src/rules/valid-expect.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab9ea9...965fa93. Read the comment docs.

[cpojer]

Thanks @SimenB

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.