jest-haste-map: only file IO errors should be silently ignored #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fixing the tests. |
added 2 commits
June 14, 2017 10:31
Codecov Report
@@ Coverage Diff @@
## master #3816 +/- ##
==========================================
- Coverage 57.64% 57.63% -0.01%
==========================================
Files 194 194
Lines 6780 6782 +2
Branches 6 6
==========================================
+ Hits 3908 3909 +1
- Misses 2869 2870 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
Nice! |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
…s#3816) * jest-haste-map: only file IO errors should be silently ignored * fix tests * remove extra line
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not proper to put all the errors in the same basket, because some types of errors, such as
SyntaxError, should definitely not be let ignored, and should instead crash the program right away.What I propose is that we reduce the errors we handle here to a very specific and reduced set, and that we progressively add more codes or kind of errors if really necessary.
This follows up #3812.
Test plan
Automated tests.