Use modern HTML5 <!DOCTYPE>, as discussed in #3299 #3937
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
cc @aaronabramov can you test whether this breaks things at FB? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #3937 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 196 196
Lines 6758 6758
Branches 6 6
=======================================
Hits 3924 3924
Misses 2831 2831
Partials 3 3
Continue to review full report at Codecov.
|
|
i should be able to do it this week! |
|
this doesn't seem to affect fb too much (3 failing tests, but i'm not sure if they're caused by this) |
KaTeX prints a spurious error message during testing. This is ultimately due to a Jest configuration issue fixed in 21.0.0. References: * KaTeX issue: KaTeX/KaTeX#664 * Jest issue: jestjs/jest#3937 * Jest fix: jestjs/jest@fcf64d79a
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
As discussed in #3299, existing tests use an old-style HTML DOCTYPE, which makes it hard to test some modern web tools such as KaTeX; see KaTeX/KaTeX#664. This small tweak uses the recommended HTML5 DOCTYPE, which is probably a better default. Other issues such as #2460 could deal with the more general problem of making this configurable, but a reasonable default seems like a good start.
Test plan
We've tested over on the KaTeX side that it removes our warning about being in quirks mode. See KaTeX/KaTeX#747 (comment)