Set coverageDirectory during normalize phase #3966
Conversation
| @@ -61,7 +62,7 @@ it('is not valid when it is a snapshot file', () => { | |||
| it('is not valid when it is a file in the coverage dir', () => { | |||
| expect( | |||
| isValidPath( | |||
| {}, | |||
| normalize({rootDir}, {}).options, | |||
| config, | |||
| path.resolve(rootDir, 'coverage', 'lib', 'index.js'), | |||
| ), | |||
There was a problem hiding this comment.
Not sure if we still need this test. The same thing is tested in normalize.test.js
|
Everything is failing! |
|
Relax, take it easy :) Fixing in a minute |
Codecov Report
@@ Coverage Diff @@
## master #3966 +/- ##
==========================================
+ Coverage 59.86% 59.87% +<.01%
==========================================
Files 196 196
Lines 6763 6764 +1
Branches 6 6
==========================================
+ Hits 4049 4050 +1
Misses 2711 2711
Partials 3 3
Continue to review full report at Codecov.
|
* Set coverageDirectory during normalize phase * Update config snapshot
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #3955.
Test plan
Added a test, update existing one.