Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipNodeResolution config option #3987

Merged
merged 1 commit into from
Jul 8, 2017

Conversation

aaronabramov
Copy link
Contributor

this option was used internally at fb but was dead code in oss version.
I'm not sure what exactly it does, but without it it takes Jest more than 2 minutes to find reverse dependencies of changed files.

i don't know if it's useful for the OSS world at all. If yes, we should document it, if not we should probably add some experimental flag or something

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6ae7b02). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3987   +/-   ##
=========================================
  Coverage          ?   60.28%           
=========================================
  Files             ?      196           
  Lines             ?     6768           
  Branches          ?        6           
=========================================
  Hits              ?     4080           
  Misses            ?     2685           
  Partials          ?        3
Impacted Files Coverage Δ
packages/jest-config/src/index.js 0% <ø> (ø)
packages/jest-resolve/src/index.js 14.01% <ø> (ø)
packages/jest-cli/src/search_source.js 76.27% <ø> (ø)
packages/jest-config/src/valid_config.js 100% <ø> (ø)
packages/jest-haste-map/src/index.js 92.96% <ø> (ø)
packages/jest-config/src/normalize.js 84.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae7b02...16d88fd. Read the comment docs.

@cpojer
Copy link
Member

cpojer commented Jul 8, 2017

Yap, this only makes sense in an environment where haste is the primary module resolution system.

@cpojer cpojer merged commit 475a95a into jestjs:master Jul 8, 2017
@aaronabramov aaronabramov deleted the skip_node_resolution branch July 8, 2017 16:58
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants