Setup for Circle 2 #4149

thymikee · 2017-07-27T22:42:07Z

Summary

This is experimental PR to switch to Circle 2.
The main advantage of v2 is "Workflows" feature, enabling easier setup for parallel builds.

There's a lot of repetitive code, but I'm not sure if we can do anything about it.

Test plan

CI pass

aaronabramov · 2017-07-27T23:12:52Z

seems like it renamed the directory from jest to project

and the other build is missing chrome for browser build

aaronabramov · 2017-07-27T23:15:40Z

you can probably share some of the values using

steps: &steps
  - checkout
  - ...

test-node-6:
  <<: *steps

thymikee · 2017-07-27T23:15:53Z

Yup, we need a docker container with chrome.
I expected Node 4 to fail, because we build files on higher Node versions.

aaronabramov · 2017-07-27T23:20:19Z

i love that we have a separate build for each version!

aaronabramov · 2017-07-27T23:35:57Z

.circleci/config.yml

+    docker:
+      - image: circleci/node:8.1.4
+    steps:
+      <<: *checkout


yeah, i don't think you can merge sequences.

thymikee · 2017-07-28T11:17:36Z

ok, got to the point where only node 4 fails.
What should we do about that, rewrite our scripts to be node-4 compatible?

aaronabramov · 2017-07-28T16:27:44Z

sent out #4153 to fix the build script on node@4!
@cpojer can we kill travis at this point?

cpojer · 2017-07-28T16:29:28Z

No, it's important that we verify Jest runs on travis. One of the primary use cases of Jest is to run on CI, and Travis is one of the most popular CI systems.

thymikee · 2017-07-28T16:36:20Z

At least we'll have faster Circle feedback ;)

aaronabramov · 2017-07-28T16:44:56Z

@cpojer that makes sense! i'll try to get travis fixed in master then.
Can we not wait for travis in PRs though? i think we'll still get a lot of signal from travis master builds (when they're fixed)

thymikee · 2017-07-28T17:27:55Z

@aaronabramov Node 4 fails, because local packages are not linked (because they're installed with npm)

aaronabramov · 2017-07-28T17:31:08Z

oh. so that's a bigger issue..
why is it installed with npm? is it yarn's fallback on old node versions?
can we use nvm on node 4 build, switch to node@8, run yarn and then switch back to node@4 and test?

thymikee · 2017-07-28T17:43:43Z

This was intentional, I'd like to know for sure if Jest can be safely installed and used on Node 4, because npm 2 produces different node_modules structure, to prevent bugs like we had when releasing jest 20

thymikee · 2017-07-28T18:49:02Z

Looks like we have eslint plugin import installed, I just need to add no-extraneous-dependencies rule so we prevent bugs caused by using transitive deps

codecov-io · 2017-07-29T21:59:57Z

Codecov Report

Merging #4149 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4149   +/-   ##
=======================================
  Coverage   60.55%   60.55%           
=======================================
  Files         196      196           
  Lines        6777     6777           
  Branches        6        6           
=======================================
  Hits         4104     4104           
  Misses       2670     2670           
  Partials        3        3

Impacted Files	Coverage Δ
...ircus/src/legacy_code_todo_rewrite/jest_adapter.js	`0% <ø> (ø)`	⬆️
packages/jest-jasmine2/src/index.js	`0% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2b647...fd68258. Read the comment docs.

aaronabramov · 2017-08-08T03:30:48Z

@cpojer are we good to merge it?

cpojer · 2017-08-08T08:51:04Z

Looks good to me. Can we make it so the website is only deployed when the tests run successfully at least in one version of node?

thymikee · 2017-08-08T08:57:49Z

Should be possible. I'll play around with that someday

Daniel15 · 2017-08-11T01:20:57Z

.circleci/config.yml

+
+  - &yarn-install
+    run: |
+      sudo npm i -g yarn@^0.27.5


The Node.js Docker image already has Yarn installed, so you shouldn't need to do this. Also, we discourage installing Yarn via npm 😃

isn't it a super old version of yarn though?
i remember i had to manually install it on travis

Travis doesn't use the Node.js Docker image. I think the Node.js image has the latest Yarn.

This docker image was using yarn 0.24, that's why I had to install it manually. Will check if that was updated

If we do want to upgrade Yarn, we should do that in a Docker image that's layered on top of another one 😃

We should at least be installing Yarn using the Debian package if the image is Debian, based, too :D

Feel free to reach out to me if you need help with it!

Would appreciate some help here, I'm not really experienced with Docker images 😄

There's docs on CircleCI's site: https://circleci.com/docs/2.0/custom-images/

I was going to submit a PR for this, but then I realised it's actually using a bunch of Docker images for various Node.js versions 😛 Initially I was going to do something like this:

# Dockerfile for building and testing Jest FROM markhobson/node-chrome MAINTAINER Daniel Lo Nigro <[email protected]> # Yarn repo ADD https://dl.yarnpkg.com/debian/pubkey.gpg /tmp/yarn-pubkey.gpg RUN apt-key add /tmp/yarn-pubkey.gpg && rm /tmp/yarn-pubkey.gpg RUN echo "deb http://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list # Crowdin repo ADD https://artifacts.crowdin.com/repo/GPG-KEY-crowdin /tmp/crowdin-pubkey.gpg RUN apt-key add /tmp/crowdin-pubkey.gpg && rm /tmp/crowdin-pubkey.gpg RUN echo "deb https://artifacts.crowdin.com/repo/deb/ /" > /etc/apt/sources.list.d/crowdin.list RUN apt-get -y update && \ apt-get install -y --no-install-recommends \ yarn \ default-jre \ crowdin \ && \ apt-get clean && \ rm -rf /var/lib/apt/lists/*

Daniel15 · 2017-08-11T01:22:03Z

.circleci/config.yml

+      # crowdin install start
+      sudo apt-get install default-jre
+      wget https://artifacts.crowdin.com/repo/deb/crowdin.deb -O crowdin.deb
+      sudo dpkg -i crowdin.deb


Ideally all required software should be installed in a Docker image so that you don't incur the cost every single time the build runs (instead it's just a once-off cost whenever you build the Docker container). That's one of the main advantages of CircleCI 2.0 :) I might submit a PR to do that, if I get a chance.

Basically, there should be some Jest dev Docker image that extends whichever other Docker images you're using, and has this stuff installed.

* Setup for Circle 2 * Try to reuse config * Fix aliases and add browser build * Adjust config * Fix save-cache alias * Add website/node_modules to alias cache * Change browser docker * Add working_directory * add yarn-install-no-sudo * Remove environment * Actually skip react-native example on Node 4 * Declare transitive deps in corresponding package.json * Install node 4 deps with yarn * Setup import/no-extraneous-dependencies rule

github-actions · 2021-05-11T22:07:02Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

thymikee requested a review from aaronabramov July 27, 2017 22:42

facebook-github-bot added the CLA Signed ✔️ label Jul 27, 2017

aaronabramov reviewed Jul 27, 2017

View reviewed changes

aaronabramov mentioned this pull request Jul 28, 2017

node@4 ./scripts/build #4153

Merged

thymikee force-pushed the circle-2 branch from ec08a99 to af2bf38 Compare July 28, 2017 16:34

aaronabramov approved these changes Jul 28, 2017

View reviewed changes

thymikee added 11 commits July 29, 2017 17:53

Setup for Circle 2

e357958

Try to reuse config

94a406d

Fix aliases and add browser build

8ea07d9

Adjust config

94279fe

Fix save-cache alias

41a1730

Add website/node_modules to alias cache

c74b3f6

Change browser docker

8a92112

Add working_directory

73436e5

add yarn-install-no-sudo

fa948d2

Remove environment

041b8b6

Actually skip react-native example on Node 4

fc85b54

Declare transitive deps in corresponding package.json

ef94054

thymikee force-pushed the circle-2 branch from 50ae336 to ef94054 Compare July 29, 2017 21:36

Install node 4 deps with yarn

b0ca73e

Setup import/no-extraneous-dependencies rule

fd68258

cpojer merged commit 4523826 into jestjs:master Aug 8, 2017

Daniel15 reviewed Aug 11, 2017

View reviewed changes

thymikee deleted the circle-2 branch March 16, 2019 10:55

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup for Circle 2 #4149

Setup for Circle 2 #4149

thymikee commented Jul 27, 2017

aaronabramov commented Jul 27, 2017

aaronabramov commented Jul 27, 2017

thymikee commented Jul 27, 2017

aaronabramov commented Jul 27, 2017

aaronabramov Jul 27, 2017

thymikee commented Jul 28, 2017

aaronabramov commented Jul 28, 2017

cpojer commented Jul 28, 2017

thymikee commented Jul 28, 2017

aaronabramov commented Jul 28, 2017

thymikee commented Jul 28, 2017

aaronabramov commented Jul 28, 2017

thymikee commented Jul 28, 2017

thymikee commented Jul 28, 2017

codecov-io commented Jul 29, 2017 •

edited

Loading

aaronabramov commented Aug 8, 2017

cpojer commented Aug 8, 2017

thymikee commented Aug 8, 2017

Daniel15 Aug 11, 2017

aaronabramov Aug 11, 2017

Daniel15 Aug 11, 2017

thymikee Aug 11, 2017

Daniel15 Aug 11, 2017

thymikee Aug 11, 2017

Daniel15 Aug 19, 2017

Daniel15 Aug 11, 2017 •

edited

Loading

github-actions bot commented May 11, 2021

Setup for Circle 2 #4149

Setup for Circle 2 #4149

Conversation

thymikee commented Jul 27, 2017

aaronabramov commented Jul 27, 2017

aaronabramov commented Jul 27, 2017

thymikee commented Jul 27, 2017

aaronabramov commented Jul 27, 2017

Choose a reason for hiding this comment

thymikee commented Jul 28, 2017

aaronabramov commented Jul 28, 2017

cpojer commented Jul 28, 2017

thymikee commented Jul 28, 2017

aaronabramov commented Jul 28, 2017

thymikee commented Jul 28, 2017

aaronabramov commented Jul 28, 2017

thymikee commented Jul 28, 2017

thymikee commented Jul 28, 2017

codecov-io commented Jul 29, 2017 • edited Loading

Codecov Report

aaronabramov commented Aug 8, 2017

cpojer commented Aug 8, 2017

thymikee commented Aug 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Daniel15 Aug 11, 2017 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 11, 2021

codecov-io commented Jul 29, 2017 •

edited

Loading

Daniel15 Aug 11, 2017 •

edited

Loading