Clarify what objects toContain and toContainEqual can be used on #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a documentation change to clarify that `toContain` and `toContainEqual` matchers work on arrays and strings (but not objects) rather than the more ambiguous "list". This also adds consistency, since all other api method docs refer to "arrays", rather than "lists".
|
👍 |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
…tjs#4307) This is just a documentation change to clarify that `toContain` and `toContainEqual` matchers work on arrays and strings (but not objects) rather than the more ambiguous "list". This also adds consistency, since all other api method docs refer to "arrays", rather than "lists".
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a documentation change to clarify that
toContainandtoContainEqualmatchers work on arrays and strings (but not objects) rather than the more ambiguous "list".This also adds consistency, since all other api method docs refer to "arrays", rather than "lists".
Summary
Test plan