Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide printText and printComment in markup.js for HTMLElement plugin #4344

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

pedrottimark
Copy link
Contributor

Summary

  • Decided against any special case for indentation “problem” of multiline strings, but found duplicate code for text nodes, therefore…
  • Refactor to encapsulate all formatting details in markup.js so the 3 plugins become adaptors for data structure of React elements, React test objects, and DOM elements.

Test plan

Existing tests

@cpojer cpojer merged commit 84b2502 into jestjs:master Aug 24, 2017
@pedrottimark pedrottimark deleted the markup-text-comment branch August 24, 2017 18:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants