fix typescript jest test crash #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_script_parser.js @line 39 failed to check if element is null before accessing the text property. ``` while (!expectText) { expectText = element.text; element = element.expression; } ``` This would crash if the callable node doesn't have the text portion: ``` [1,2,3].forEach(n => {...}); ``` Fix is easy, also added a test case.
Codecov Report
@@ Coverage Diff @@
## master #4363 +/- ##
=======================================
Coverage 55.85% 55.85%
=======================================
Files 189 189
Lines 6383 6383
Branches 6 6
=======================================
Hits 3565 3565
Misses 2815 2815
Partials 3 3
Continue to review full report at Codecov.
|
|
Perfect - thanks @connectdotz And thanks for poking me @cpojer 👍 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vscode-jest failed to highlight failed jest tests on editor, due to the
packages/jest-test-typescript-parser/test_script_parser.jscrash:Basically,
test_script_parser.js@line 40 failed to check ifelementis null before callingelement.text.This would crash if the callable node doesn't have the text portion:
Fix is easy and minimal, also added a test case, see below.
Test plan
fixures/CallExpressionWithoutText.examplefixures/parser_tests.js