Make listTests always print to console.log

[jseminck]

Summary
Always print the output of the --listTests option to console.log, even when using --json flag (which is otherwise redirected to stderr) or the --stdErr flag.

See issue: #4388

Test plan
Updated the existing test

[aaronabramov]

Thanks!
seems like one of the tests is failing because console.log adds the \n the end. I don't think it's a big deal and we can keep it there.
You do need to update the snapshot though :)

[jseminck]

Updated 😄 I wanted to see the results from CI because I'm on Windows at the moment and some tests are unstable for me.

[jseminck]

The test passes on my WIndows machine... Will try again on my mac but only have access to it tomorrow!

[cpojer]

Seems like the test is failing on AppVeyor.

[jseminck]

Yeah - I noticed the same on my Windows pc at home. The test output is different on Win/Mac. I'll investigate further when I have both machines available at the same time 😄

But it seems like for Windows there's an additional \n added?

[jseminck]

Sorry for the additional commits, but it was the fastest way for me to test between Mac/Windows. If you want me to squash them, let me know.

I eventually ended up finding a way that the test passes on both machines, though I do not understand how it worked before. The issue (I think) is that in the test files we were splitting and joining with EOL from the os package (which probably was different for the Windows tests).

AppVeyor now started failing on some other tests - but that seems not to be related to my changes? Is it possible to restart?

[cpojer]

Thank you.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.