Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): Handle ignored files in babel v7 #4393

Merged
merged 3 commits into from
Aug 31, 2017
Merged

fix(babel): Handle ignored files in babel v7 #4393

merged 3 commits into from
Aug 31, 2017

Conversation

danez
Copy link
Contributor

@danez danez commented Aug 30, 2017

Summary

In babel v7 babel-core.transform() returns null if a file is ignored.
This change makes babel-jest not throw a TypeError in this case.

Test plan

Tested by modifying local installed babel-jest in babel, while trying to get jest running in babel itself.

In babel v7 `babel-core.transform()` might return null if a file is ignored.
This makes babel-jest not throw a TypeError in this case.
@codecov-io
Copy link

codecov-io commented Aug 30, 2017

Codecov Report

Merging #4393 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4393   +/-   ##
=======================================
  Coverage   56.17%   56.17%           
=======================================
  Files         191      191           
  Lines        6424     6424           
  Branches        6        6           
=======================================
  Hits         3609     3609           
  Misses       2812     2812           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a61bb...7500fe3. Read the comment docs.

@cpojer cpojer merged commit 60b93b9 into jestjs:master Aug 31, 2017
@cpojer
Copy link
Member

cpojer commented Aug 31, 2017

Thanks for submitting a fix :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants