Take precedence of NODE_PATH when resolving node_modules directories #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4453 +/- ##
=======================================
Coverage 56.74% 56.74%
=======================================
Files 189 189
Lines 6485 6485
Branches 3 3
=======================================
Hits 3680 3680
Misses 2804 2804
Partials 1 1
Continue to review full report at Codecov.
|
|
@kittens - Can you provide a bit more context on this change? We bisected jest module resolution errors to this commit, specifically for our team members whose NODE_PATH variable contains one or more paths that don't exist on their system. Before this change, the nonexistent paths would be further down the resolution paths array and the error wouldn't occur. In a related note, jest should probably skip resolving modules in nonexistent directories instead of fail with the following error: Edit: looking more at this, I think the correct solution is to throw a clearer error including the attempted module resolution path. |
wschurman
added a commit
to wschurman/jest
that referenced
this pull request
Sep 14, 2017
…tion directory does not exist Summary: A recent change to take precedence of NODE_PATH for module resolution (jestjs#4453) made this issue more likely to occur since NODE_PATH could contain non-existent directories. While this could have occurred prior to the change, it was less likely since it is more common that modules are in local `node_modules`. Either way, non-existent directories should be treated the same way as non-existent files during module resolution. The equivalent case for `statSync` returning `ENOENT` for files is `ENOTDIR` for directories. We may want to add `ENOTDIR` to `isFile` as well. Test Plan: 1. `yarn test` 2. Link cli into another project, set NODE_PATH to non-existent directories, no longer see cryptic `Cannot find module` error. Instead, it now resolves to a potential path further down the path list.
cpojer
pushed a commit
that referenced
this pull request
Sep 15, 2017
…tion directory does not exist (#4483) Summary: A recent change to take precedence of NODE_PATH for module resolution (#4453) made this issue more likely to occur since NODE_PATH could contain non-existent directories. While this could have occurred prior to the change, it was less likely since it is more common that modules are in local `node_modules`. Either way, non-existent directories should be treated the same way as non-existent files during module resolution. The equivalent case for `statSync` returning `ENOENT` for files is `ENOTDIR` for directories. We may want to add `ENOTDIR` to `isFile` as well. Test Plan: 1. `yarn test` 2. Link cli into another project, set NODE_PATH to non-existent directories, no longer see cryptic `Cannot find module` error. Instead, it now resolves to a potential path further down the path list.
tabrindle
pushed a commit
to tabrindle/jest
that referenced
this pull request
Oct 2, 2017
tabrindle
pushed a commit
to tabrindle/jest
that referenced
this pull request
Oct 2, 2017
…tion directory does not exist (jestjs#4483) Summary: A recent change to take precedence of NODE_PATH for module resolution (jestjs#4453) made this issue more likely to occur since NODE_PATH could contain non-existent directories. While this could have occurred prior to the change, it was less likely since it is more common that modules are in local `node_modules`. Either way, non-existent directories should be treated the same way as non-existent files during module resolution. The equivalent case for `statSync` returning `ENOENT` for files is `ENOTDIR` for directories. We may want to add `ENOTDIR` to `isFile` as well. Test Plan: 1. `yarn test` 2. Link cli into another project, set NODE_PATH to non-existent directories, no longer see cryptic `Cannot find module` error. Instead, it now resolves to a potential path further down the path list.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This aligns Jest with the behaviour of Node where it takes precedence of
NODE_PATHover resolving modules relative tonode_modules.Test plan
yolo