Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call chalk.inverse for trailing spaces in jest-matcher-utils #4578

Merged
merged 1 commit into from
Oct 1, 2017

Conversation

pedrottimark
Copy link
Contributor

Summary

Reduce package coupling and eliminate potential inconsistency between fg and bg colors.

Make printExpected and printReceived follow example of printActualErrorMessage to color trailing spaces within the string before coloring the entire string, because closing escape sequence for foreground color preceding newline causes regex for background color not to match.

Test plan

  • Added a snapshot (with wrong result at first) of improved behavior in matchers.test.js
  • Attached screen shot to confirm no regression in to-throw-matchers.js

2017-10-01 to-throw-error

P.S. Again to Yarn team: we who are about to test (package interdependencies) salute you!

@codecov-io
Copy link

Codecov Report

Merging #4578 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4578      +/-   ##
==========================================
- Coverage   55.65%   55.63%   -0.02%     
==========================================
  Files         186      186              
  Lines        6350     6348       -2     
  Branches        3        3              
==========================================
- Hits         3534     3532       -2     
  Misses       2815     2815              
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-matcher-utils/src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff7a1c...8852ce5. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants