Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4588 error text inline function #4593

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Fix #4588 error text inline function #4593

merged 1 commit into from
Oct 3, 2017

Conversation

01binary
Copy link
Contributor

@01binary 01binary commented Oct 3, 2017

Summary

Update error message in babel-plugin-jest-hoist to specify only inline functions are accepted as a second parameter to jest.mock (explicit automock).

We spent some time troubleshooting because it refused to accept any function we gave to it, until I read the code and saw that previously declared functions get seen as "identifiers", only inline/arrow functions are seen as "function".

Test plan

Not familiar with test strategy for error messages, if the builds fail I will modify whatever tests assert on that error message.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #4593 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4593   +/-   ##
=======================================
  Coverage   55.68%   55.68%           
=======================================
  Files         186      186           
  Lines        6348     6348           
  Branches        3        3           
=======================================
  Hits         3535     3535           
  Misses       2812     2812           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cda2e2...b7e58b0. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants