Add testPath to jest-jasmine2 reporter callbacks

[palmerj3]

Summary

Adds testPath to jest-jasmine2 reporter callbacks.
For jest reporter callbacks such as onTestStart we are provided with the associated file path of the test being reported on. This adds this functionality to jest-jasmine2 reporters.

My personal (and organizational) need for this is that I need a jasmine reporter that is capable of properly uniquely identifying a particular test block. I do this by utilizing both the fullName and the relative file path of the test.

For large projects it is not at all unheard of for fullName (e.g. nested test description + it block description) to not be unique.

Before (specStarted):

{
      id: 'spec0',
      description: 'should play',
      fullName: 'playlist should play',
      failedExpectations: [],
      passedExpectations: [],
      pendingReason: ''
}

After (specStarted):

{
      id: 'spec0',
      description: 'should play',
      fullName: 'playlist should play',
      failedExpectations: [],
      passedExpectations: [],
      pendingReason: '',
      testPath: '/Users/jpalmer/Desktop/test/__tests__/foo.test.js' 
}

Test plan

Ran all tests

I see there is not much in the way of tests for jasmine reporters. An integration test might be nice in this case at the top level. Let me know if you'd like me to try adding that.

[palmerj3]

This handles my original needs mentioned in #4471

[palmerj3]

@aaronabramov perhaps you want to take a look since you're working on some reporter stuff & things :)

[codecov-io]

Codecov Report

Merging #4594 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4594      +/-   ##
==========================================
- Coverage   55.68%   55.67%   -0.01%     
==========================================
  Files         186      186              
  Lines        6348     6349       +1     
  Branches        3        3              
==========================================
  Hits         3535     3535              
- Misses       2812     2813       +1     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-jasmine2/src/jasmine/Spec.js	0% <ø> (ø)	⬆️
packages/jest-jasmine2/src/jasmine/Env.js	0% <0%> (ø)	⬆️
packages/jest-jasmine2/src/index.js	0% <0%> (ø)	⬆️
...ackages/jest-jasmine2/src/jasmine/jasmine_light.js	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bc5ad...497d6f0. Read the comment docs.

[aaronabramov]

look good to me :)

[cpojer]

Instead of adding this to Jasmine, could we instead patch the results object like we do for snapshots below on line 110?

See https://github.com/facebook/jest/pull/4594/files#diff-e4399d1682ddb42f8a43f1a917d42d87R110

[palmerj3]

I'll give that a shot

[palmerj3]

@cpojer so I think that code is what deals with jest reporters not with jasmine reporters. Jasmine reporters are what I'm trying to modify because currently jest reporters do not provide callbacks for when an individual test is going to be run. The lowest level offered for those are before a describe block is run.

[cpojer]

alright.

[Vanuan]

Wow, I've just stumbled across this issue (duplicate suite names).
It's astonishing that this was merged just yesterday.
#4607

[Vanuan]

It looks like this is only added to the test spec. Would it be possible to add this to test suite too?

[Vanuan]

Please, review #5394

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.