Fix errors when identity-obj-proxy mocks CSS Modules #4935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4580 and #4922
Because the mock identity object for CSS Modules returns the key as the value for any key:
true
avoids false positive inImmutable
plugintest
methodval.constructor === 'function'
avoids undefined as name of objectSee Mocking CSS Modules
Test plan
Added 2 tests which failed before changes to code, and then fixed them to fail for right reason :)