Exclude files from running if they match with the ignoring pattern #5341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the existence of a file into a project via getting all files from haste is not enough. The reason for that is that a parent project might have a child project inside it, which all of its files explicitly blacklisted.
I've added an extra refinement step, where the full file paths are run through the
testPathIgnorePatterns
method, and returningfalse
if they match (note: the result of the method is reversed, so the!
in front of the call is correct).I also changed the test to create this particular use case, and verified that it fails on master but passes on the PR. Added entry in
CHANGELOG.md
as well.It might also potentially fix #5332.