jest-haste-map: fix bug where platform-specific files are removed #5534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix for
jest-haste-map
😁This changeset fixes the bug that was reproduced by the test I added a few days ago, where platform-specific file removals aren't taken into account. I traced this back to the fact the logic just copies the entire module metadata for a particular Haste name, without discriminating between platforms. That means if any of the files for that Haste name is still here, all the platforms already cached are included in the new map, even if some of these files were deleted. With the new logic, we only copy over the data for the platform of the file being processed.
I didn't check how that behaves for the watch mode but I suspect this fixes the bug for it as well. I can follow up with another test for that.