Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple glob patterns for collectCoverageFrom #5537

Merged
merged 3 commits into from
Feb 12, 2018

Conversation

ronami
Copy link
Contributor

@ronami ronami commented Feb 12, 2018

This PR address issue #5198.

Summary

Improves the behaviour of collectCoverageFrom CLI option by allowing passing multiple glob patterns.

For example:

jest --collectCoverageFrom foo/**/*.js bar/**/*.js

Test plan

I added a simple integration test that covers this use case.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #5537 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5537   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files         213      213           
  Lines        7149     7149           
  Branches        4        4           
=======================================
  Hits         4412     4412           
  Misses       2736     2736           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c342a...f251fe7. Read the comment docs.

@cpojer cpojer merged commit 133a9a1 into jestjs:master Feb 12, 2018
@ronami ronami deleted the collect-coverage-from-multiple branch February 12, 2018 22:00
jessecarfb pushed a commit to jessecarfb/jest that referenced this pull request Feb 14, 2018
* support multiple glob patterns for collectCoverageFrom

* add changelog for multiple globs for collectCoverageFrom cli option

* update snapshot for coverage_report.test.js
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants